Leaves - Katie & Cloudy #10

KKennedyCodes · 2019-10-11T22:12:29Z

Rideshare-Rails

Congratulations! You're submitting your assignment! These comprehension questions should be answered by both partners together, not by a single teammate.

Comprehension Questions

Question	Answer
Describe the types of entity relationships you set up in your project and why you set up the relationships that way	We set up our program so that passenger and driver belonged to trip and that trip has many passengers and drivers. We wanted to be able to access all of the driver and passenger information from the trips.
Describe the role of model validations in your application	We used model validations to check and validate key params for both drivers and passengers. We also added that there can only be one vin in use and one phone number to test for uniqueness.
How did your team break up the work to be done?	To break up the work we started by adding all of the tasks to the trello board. Cloudy was responsible of the drivers and Katie was responsible for passengers, trips, and css.
What features did you choose to prioritize in your project, and what features, if any, did you have to set aside to meet the deadline?	We wanted to be sure to deploy as working web app. We had to leave some unpassing trip tests due to a roadblock and we also deferred the auto driver select till the end and we ran out of time to complete. We also had to sacrifice some additional testing due to the time constraints.
What was one thing that your team collectively gained more clarity on after completing this assignment?	The MVC model and the relationships between them.
What is your Trello board URL?	https://trello.com/b/KXa2pvnz/rideshare-rails
What is the Heroku URL of your deployed application?	https://rideshare-kk-cl.herokuapp.com/
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share?	We discussed the successes we found in using the trello board for workflow and asking for help earlier to save time and gain applicable knowledge from those who have a better understanding.

KK/passengers

…ndle trips.

Started setting up trips, but stuck. Need to decide how we want to h…

…now delete edit view all drivers

Added Trip List for Passengers and Total Amount Spent

…h_trips Kk/PassengerValidation&Model_Formulas

Kk/adding new trip

Generates Random Amount to Charge

…rails completed all driver controller tests

…ageS controller

Automatically Adds Trip

…rails completed drivers model and show

Cssupdates

toggle TOGGLES FOR AVAILBILITY. YESSSS

Adding trip tests continued

beccaelenzil · 2019-10-18T17:16:05Z

Rideshare Rails

What We're Looking For

Feature	Feedback
Baseline
Appropriate git usage with no extraneous files checked in and all team members contributing	check
Answered comprehension questions	check
Uses named routes (like `_path`)	check
RESTful routes utilized	check
Project Requirements
Table relationships	check
Validation rules for Models	check
Business logic is in the models	For costs, it's best practice to round to 2 decimal places.
Tests for validations	check
Tests for relationships	check
Tests for custom model methods	I don't see these -- The lessons this week should help with this understanding, but let me know if you have questions
Tests for controller actions	Remember to always test for failure and success cases.
Database is seeded from the CSV files	check
Trello board is created and utilized in project management	check
Heroku instance is online	check
The app is styled to create an attractive user interface	check -- nice user experience!
Overall	Good work overall. It is clear to me that the learning goals around model relationships, validations, and seeding were met. I was not able to run your tests. From inspection, it looks like controller tests are fairly complete, but could use so tests of failure cases. Keep up the hard work!

…nish.

KKennedyCodes and others added 30 commits October 7, 2019 15:29

setting up rails

fad2934

Created Models

6579471

Added Relationships

49a9588

Database Seeded

17e5249

Added Models, Seeded Database, and Verified Seeding

6bf5e43

Passengers, Drivers, Trips Controllers Created

f02f495

Added Content to Index Method

2875c0a

Added Show Method to Passengers, Drivers, and Trips

2c414ec

Added Routes

3f84fcd

Added View html.erb files

cdcaa17

first commit for new drives class

fc95128

added drivers index show for all drivers

98f017d

Added Index Page

a8c4d54

added show logic to see list of all drivers and a single driver.

fbb8ab8

Add Passenger Form Created

bb39eeb

updating passenger form

5b23bc2

Add New Passenger Form Working

d8b6d04

Edit Passenger Form Completed

0d4a1a4

Can Delete Passenger

6b7d02d

Added Basic Nav Bar Function

f671d2b

Updated Passenger Tests Sent from Jared

e285228

Merge pull request #1 from KKennedyCodes/kk/passengers

cfcfc2a

KK/passengers

Started setting up trips, but stuck. Need to decide how we want to ha…

b7b3e7d

…ndle trips.

Merge pull request #2 from KKennedyCodes/kk/trips

3e24099

Started setting up trips, but stuck. Need to decide how we want to h…

completed all logic in view model index form show for driver. we can …

8dfbd0e

…now delete edit view all drivers

Added Trip List for Passengers and Total Amout Spent

593e928

Merge pull request #3 from KKennedyCodes/kk/add_trip_list_to_passenger

db170a0

Added Trip List for Passengers and Total Amount Spent

Added Error Handling for Incorrect Input for New Passenger

aa4fa37

Edited Passenger Show

23c9392

Merge pull request #4 from KKennedyCodes/kk/passenger_interaction_wit…

df4a4d8

…h_trips Kk/PassengerValidation&Model_Formulas

KKennedyCodes and others added 28 commits October 10, 2019 14:01

Fixed Cost Update Error

306d474

Merge branch 'master' into kk/adding_new_trip

1b8cb57

Merge pull request #7 from KKennedyCodes/kk/adding_new_trip

dc33928

Kk/adding new trip

Generates Random Amount to Charge

d2bb0c8

Merge pull request #8 from KKennedyCodes/fixing_monies

96a75fb

Generates Random Amount to Charge

CONTROLLER TESTS FINISHED AND PASSING

bafd4d9

Merge branch 'master' of https://github.com/KKennedyCodes/ride-share-…

3ef4b3a

…rails completed all driver controller tests

created homepage controller and realized thats wrong, recreated homep…

f17339f

…ageS controller

Automatically Adds Trip

e452aa7

Merge pull request #9 from KKennedyCodes/fixing_monies

2faa775

Automatically Adds Trip

fixed drivers edit page to save and route properly

f51d282

Added Homepage Route

8132ec4

Finished Auto Complete Date for Add Trip, Created Trip Views

50a54ff

Changes to Edit

cd33c27

completed drivers model and show.

60eb0a8

Merge branch 'master' of https://github.com/KKennedyCodes/ride-share-…

6bbcb33

…rails completed drivers model and show

Added CSS

0caa73a

Further CSS changes

16230d9

Merge pull request #10 from KKennedyCodes/cssupdates

7e9c66e

Cssupdates

Adding Basic Test Outline

db7036b

poushing and pulling to get up to speed

7314d7a

fixing driver toggle logic

535f825

testing still under construction

98e87eb

working on toggle for status availability. otherwise, everything works.

5fa903e

toggle TOGGLES FOR AVAILBILITY. YESSSS

b696b3c

Merge pull request #11 from KKennedyCodes/toggle

86b6e55

toggle TOGGLES FOR AVAILBILITY. YESSSS

tests added, still not passing

3e66d3d

Merge pull request #12 from KKennedyCodes/adding_trip_tests_continued

d186e41

Adding trip tests continued

fleshing out the controller for orders. not complete, will pair to fi…

9b35b70

…nish.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Leaves - Katie & Cloudy #10

Leaves - Katie & Cloudy #10

KKennedyCodes commented Oct 11, 2019

beccaelenzil commented Oct 18, 2019

Leaves - Katie & Cloudy #10

Are you sure you want to change the base?

Leaves - Katie & Cloudy #10

Conversation

KKennedyCodes commented Oct 11, 2019

Rideshare-Rails

Comprehension Questions

beccaelenzil commented Oct 18, 2019

Rideshare Rails

What We're Looking For